Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multi-select option to column editVariant parameter #357

Merged
merged 2 commits into from
Jul 11, 2024
Merged

feat: add multi-select option to column editVariant parameter #357

merged 2 commits into from
Jul 11, 2024

Conversation

yann-combarnous
Copy link
Contributor

This PR adds a multi-select option to the columnOption: 'editVariant'.

In Mantine, Select and MultiSelect have the same properties, so extending this MRT option should not bring conflicts.

@vercel Vercel
Copy link

vercel bot commented Jun 13, 2024

@yann-combarnous is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@alessandrojcm
Copy link
Collaborator

Hi @yann-combarnous thanks for your PR, please see my comments when you get a chance.

@yann-combarnous
Copy link
Contributor Author

Hi @yann-combarnous thanks for your PR, please see my comments when you get a chance.

Sure, but not seeing any atm??

@alessandrojcm
Copy link
Collaborator

Hi @yann-combarnous thanks for your PR, please see my comments when you get a chance.

Sure, but not seeing any atm??

Sorry forgo to tick submit review, please check now.

@yann-combarnous
Copy link
Contributor Author

Hi @yann-combarnous thanks for your PR, please see my comments when you get a chance.

Sure, but not seeing any atm??

Sorry forgo to tick submit review, please check now.

Thx, added a fix attempt, please have a look. It also solves the previously existing @ts-ignore for the Select component.

alessandrojcm
alessandrojcm approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@alessandrojcm alessandrojcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@alessandrojcm alessandrojcm merged commit f40f42f into KevinVandy:v2 Jul 11, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrojcm alessandrojcm alessandrojcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yann-combarnous @alessandrojcm